issue_comments

Table actions

10 rows where author_association = "MEMBER" and issue = 682040124 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • update the instructions in the contributing guide · 10 ✖

author_association 1

  • MEMBER · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
677920120 https://github.com/pydata/xarray/pull/4355#issuecomment-677920120 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3NzkyMDEyMA== shoyer 1217238 2020-08-20T21:40:05Z 2020-08-20T21:40:05Z MEMBER

Or should I just open a tracking issue for this and put it into the Documentation & User Engagement board?

This sounds good to me!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124
677502566 https://github.com/pydata/xarray/pull/4355#issuecomment-677502566 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3NzUwMjU2Ng== keewis 14808389 2020-08-20T09:59:40Z 2020-08-20T09:59:40Z MEMBER

Just so we don't forget: do we have a place where we collect ideas for the restructuring of the docs? Or should I just open a tracking issue for this and put it into the Documentation & User Engagement board?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124
677087009 https://github.com/pydata/xarray/pull/4355#issuecomment-677087009 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3NzA4NzAwOQ== shoyer 1217238 2020-08-20T05:06:34Z 2020-08-20T05:06:34Z MEMBER

Thanks @keewis! This is indeed worth updating.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124
676821998 https://github.com/pydata/xarray/pull/4355#issuecomment-676821998 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3NjgyMTk5OA== keewis 14808389 2020-08-20T00:07:04Z 2020-08-20T00:07:04Z MEMBER

so I guess this is ready for review and merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124
676817977 https://github.com/pydata/xarray/pull/4355#issuecomment-676817977 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3NjgxNzk3Nw== keewis 14808389 2020-08-19T23:51:40Z 2020-08-19T23:51:40Z MEMBER

phew, it seems having support set a feature flag to not do shallow clones fixed that particular issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124
676784625 https://github.com/pydata/xarray/pull/4355#issuecomment-676784625 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3Njc4NDYyNQ== keewis 14808389 2020-08-19T22:39:29Z 2020-08-19T22:39:29Z MEMBER

okay, so it seems this happens because RTD only makes shallow copies, as soon as we call git fetch --unshallow, the version detection works again.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124
676746088 https://github.com/pydata/xarray/pull/4355#issuecomment-676746088 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3Njc0NjA4OA== max-sixty 5635139 2020-08-19T22:03:05Z 2020-08-19T22:03:05Z MEMBER

re contributing docs: would it be best to leave that to the planned docs overhaul?

For sure, I didn't mean to weigh down this PR

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124
676736067 https://github.com/pydata/xarray/pull/4355#issuecomment-676736067 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3NjczNjA2Nw== keewis 14808389 2020-08-19T21:54:19Z 2020-08-19T21:54:19Z MEMBER

re contributing docs: would it be best to leave that to the planned docs overhaul?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124
676735131 https://github.com/pydata/xarray/pull/4355#issuecomment-676735131 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3NjczNTEzMQ== keewis 14808389 2020-08-19T21:52:28Z 2020-08-19T21:52:28Z MEMBER

ugh. It seems this is the same error as in #4130. This time I can reproduce it locally, though, so now I'm debugging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124
676708744 https://github.com/pydata/xarray/pull/4355#issuecomment-676708744 https://api.github.com/repos/pydata/xarray/issues/4355 MDEyOklzc3VlQ29tbWVudDY3NjcwODc0NA== max-sixty 5635139 2020-08-19T21:15:47Z 2020-08-19T21:15:47Z MEMBER

Agree with these changes, thanks @keewis

Stepping back on the contributing doc — I admit I haven't look at it in a while — I wonder whether we can slim it down a bit, for example by linking to other docs for generic tooling — I imagine we're unlikely to have the best docs on working with GH, for example. Or referencing our PR template rather than the (now out-of-date) PR checklist.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update the instructions in the contributing guide 682040124

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);