issues: 682040124

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
682040124 MDExOlB1bGxSZXF1ZXN0NDcwMzMyMDM4 4355 update the instructions in the contributing guide 14808389 closed 0     10 2020-08-19T18:15:15Z 2020-08-20T21:40:05Z 2020-08-20T05:06:38Z MEMBER   0 pydata/xarray/pulls/4355

Our contributing guide is out-of-date, we usually use merge commits instead of rebasing (which would require force-pushing). This has already lead to confusion, see #4314.

Also, I noticed that in Delete your merged branch it recommends to use git branch -d <feature-branch> after updating master. That doesn't work anymore because we've switched to squash-merges.

  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4355/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables