issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 668141561 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Silence sphinx warnings · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
676493029 https://github.com/pydata/xarray/pull/4286#issuecomment-676493029 https://api.github.com/repos/pydata/xarray/issues/4286 MDEyOklzc3VlQ29tbWVudDY3NjQ5MzAyOQ== max-sixty 5635139 2020-08-19T15:22:21Z 2020-08-19T15:22:21Z MEMBER

A Napoleonic PR! (pun intended)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 668141561
676479650 https://github.com/pydata/xarray/pull/4286#issuecomment-676479650 https://api.github.com/repos/pydata/xarray/issues/4286 MDEyOklzc3VlQ29tbWVudDY3NjQ3OTY1MA== dcherian 2448579 2020-08-19T14:59:39Z 2020-08-19T14:59:39Z MEMBER

Thanks @keewis. Great work!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 668141561
673150613 https://github.com/pydata/xarray/pull/4286#issuecomment-673150613 https://api.github.com/repos/pydata/xarray/issues/4286 MDEyOklzc3VlQ29tbWVudDY3MzE1MDYxMw== keewis 14808389 2020-08-12T23:00:10Z 2020-08-12T23:00:44Z MEMBER

most of the remaining broken links are due to other sections (mostly the See Also section). To fix that, napoleon has to first add support for preprocessing those sections.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 668141561
673079286 https://github.com/pydata/xarray/pull/4286#issuecomment-673079286 https://api.github.com/repos/pydata/xarray/issues/4286 MDEyOklzc3VlQ29tbWVudDY3MzA3OTI4Ng== dcherian 2448579 2020-08-12T19:57:06Z 2020-08-12T19:57:06Z MEMBER

@keewis: this is great!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 668141561
671049978 https://github.com/pydata/xarray/pull/4286#issuecomment-671049978 https://api.github.com/repos/pydata/xarray/issues/4286 MDEyOklzc3VlQ29tbWVudDY3MTA0OTk3OA== keewis 14808389 2020-08-09T13:06:49Z 2020-08-09T18:35:11Z MEMBER

unfortunately, we won't be able to get this to work until the defaults channel includes sphinx version 3.2.0: pinning sphinx in doc.yml doesn't work, RTD will install sphinx from defaults, even if there's already a sphinx version installed. There has already been some effort to fix that, but I don't know if there was any progress on this since then.

Edit: I guess we could ask support to add a feature flag (CONDA_APPEND_CORE_REQUIREMENTS), which might help with that. Edit: see readthedocs/readthedocs.org#7371

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 668141561
670015371 https://github.com/pydata/xarray/pull/4286#issuecomment-670015371 https://api.github.com/repos/pydata/xarray/issues/4286 MDEyOklzc3VlQ29tbWVudDY3MDAxNTM3MQ== max-sixty 5635139 2020-08-06T15:54:39Z 2020-08-06T15:54:39Z MEMBER

Thanks a lot @keewis !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 668141561
667361752 https://github.com/pydata/xarray/pull/4286#issuecomment-667361752 https://api.github.com/repos/pydata/xarray/issues/4286 MDEyOklzc3VlQ29tbWVudDY2NzM2MTc1Mg== spencerkclark 6628425 2020-07-31T21:21:16Z 2020-07-31T21:21:16Z MEMBER

Anyway, I don't think any of those is part of the public api? If the methods on CFTimeIndex are public, I think we either shouldn't reference these classes or make them public (or add a glossary term to define what CFTimeOffset means).

Thanks for catching this; I agree they are not currently public API, so let's remove the references to them in docstrings of public functions. And it's true, I think CFTimeOffset would be a better name for the base class, but we can wait until later to act on that.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 668141561
667355871 https://github.com/pydata/xarray/pull/4286#issuecomment-667355871 https://api.github.com/repos/pydata/xarray/issues/4286 MDEyOklzc3VlQ29tbWVudDY2NzM1NTg3MQ== keewis 14808389 2020-07-31T21:04:09Z 2020-07-31T21:04:09Z MEMBER

@spencerkclark, while working on this PR I got a warning about CFTimeOffset not being linkable in CFTimeIndex.floor / ceil / round. Looking through the code, I can only find BaseCFTimeOffset, there's no CFTimeOffset class (maybe we should rename that base class?).

Anyway, I don't think any of those is part of the public api? If the methods on CFTimeIndex are public, I think we either shouldn't reference these classes or make them public (or add a glossary term to define what CFTimeOffset means).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Silence sphinx warnings 668141561

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);