issue_comments: 667361752

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4286#issuecomment-667361752 https://api.github.com/repos/pydata/xarray/issues/4286 667361752 MDEyOklzc3VlQ29tbWVudDY2NzM2MTc1Mg== 6628425 2020-07-31T21:21:16Z 2020-07-31T21:21:16Z MEMBER

Anyway, I don't think any of those is part of the public api? If the methods on CFTimeIndex are public, I think we either shouldn't reference these classes or make them public (or add a glossary term to define what CFTimeOffset means).

Thanks for catching this; I agree they are not currently public API, so let's remove the references to them in docstrings of public functions. And it's true, I think CFTimeOffset would be a better name for the base class, but we can wait until later to act on that.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   668141561