issue_comments: 667355871

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4286#issuecomment-667355871 https://api.github.com/repos/pydata/xarray/issues/4286 667355871 MDEyOklzc3VlQ29tbWVudDY2NzM1NTg3MQ== 14808389 2020-07-31T21:04:09Z 2020-07-31T21:04:09Z MEMBER

@spencerkclark, while working on this PR I got a warning about CFTimeOffset not being linkable in CFTimeIndex.floor / ceil / round. Looking through the code, I can only find BaseCFTimeOffset, there's no CFTimeOffset class (maybe we should rename that base class?).

Anyway, I don't think any of those is part of the public api? If the methods on CFTimeIndex are public, I think we either shouldn't reference these classes or make them public (or add a glossary term to define what CFTimeOffset means).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   668141561