issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 573768194 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Add template xarray object kwarg to map_blocks · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
624759540 https://github.com/pydata/xarray/pull/3816#issuecomment-624759540 https://api.github.com/repos/pydata/xarray/issues/3816 MDEyOklzc3VlQ29tbWVudDYyNDc1OTU0MA== dcherian 2448579 2020-05-06T16:41:48Z 2020-05-06T16:41:48Z MEMBER

Thanks for the reviews everyone.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add template xarray object kwarg to map_blocks 573768194
624221236 https://github.com/pydata/xarray/pull/3816#issuecomment-624221236 https://api.github.com/repos/pydata/xarray/issues/3816 MDEyOklzc3VlQ29tbWVudDYyNDIyMTIzNg== dcherian 2448579 2020-05-05T18:14:06Z 2020-05-05T18:14:06Z MEMBER

Added docs on attrs issue. This should be good to go.

Thanks for the kind words, @bradyrx 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add template xarray object kwarg to map_blocks 573768194
622140922 https://github.com/pydata/xarray/pull/3816#issuecomment-622140922 https://api.github.com/repos/pydata/xarray/issues/3816 MDEyOklzc3VlQ29tbWVudDYyMjE0MDkyMg== shoyer 1217238 2020-04-30T22:05:50Z 2020-04-30T22:05:50Z MEMBER

I think it's also a good idea to use a different name from dask's meta because template is used differently. It's an object with the full shape of the desired output, not size 0 dimensions.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add template xarray object kwarg to map_blocks 573768194
622128514 https://github.com/pydata/xarray/pull/3816#issuecomment-622128514 https://api.github.com/repos/pydata/xarray/issues/3816 MDEyOklzc3VlQ29tbWVudDYyMjEyODUxNA== TomAugspurger 1312546 2020-04-30T21:38:21Z 2020-04-30T21:38:21Z MEMBER

Makes sense. template seems fine.

On Thu, Apr 30, 2020 at 3:35 PM Deepak Cherian notifications@github.com wrote:

Thanks for the review @TomAugspurger https://github.com/TomAugspurger

Question on the name template. I think in dask.dataframe and dask.array we might call this meta. Is that keyword already used elsewhere in xarray? template is also a fine name though.

I added the meta kwarg to apply_ufunc so that users could pass that down to dask i.e. that meta = dask's meta = np.ndarray or something like that. So I'd like to avoid reusing meta here where it would exclusively be an xarray object ≠ dask's meta

BUT it seems to me like there's a better name than template. Any ideas?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3816#issuecomment-622095710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAOIQWE7DGYAOSJWLG5F3RPHOI7ANCNFSM4K7ODDRA . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add template xarray object kwarg to map_blocks 573768194
622095710 https://github.com/pydata/xarray/pull/3816#issuecomment-622095710 https://api.github.com/repos/pydata/xarray/issues/3816 MDEyOklzc3VlQ29tbWVudDYyMjA5NTcxMA== dcherian 2448579 2020-04-30T20:35:13Z 2020-04-30T20:35:13Z MEMBER

Thanks for the review @TomAugspurger

Question on the name template. I think in dask.dataframe and dask.array we might call this meta. Is that keyword already used elsewhere in xarray? template is also a fine name though.

I added the meta kwarg to apply_ufunc so that users could pass that down to dask i.e. that meta = dask's meta = np.ndarray or something like that. So I'd like to avoid reusing meta here where it would exclusively be an xarray object ≠ dask's meta

BUT it seems to me like there's a better name than template. Any ideas?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add template xarray object kwarg to map_blocks 573768194
621601134 https://github.com/pydata/xarray/pull/3816#issuecomment-621601134 https://api.github.com/repos/pydata/xarray/issues/3816 MDEyOklzc3VlQ29tbWVudDYyMTYwMTEzNA== shoyer 1217238 2020-04-30T04:11:22Z 2020-04-30T04:11:22Z MEMBER

Looks really nice! I like this design, just a few minor concerns.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add template xarray object kwarg to map_blocks 573768194
601887703 https://github.com/pydata/xarray/pull/3816#issuecomment-601887703 https://api.github.com/repos/pydata/xarray/issues/3816 MDEyOklzc3VlQ29tbWVudDYwMTg4NzcwMw== dcherian 2448579 2020-03-20T20:04:06Z 2020-03-20T20:04:06Z MEMBER

Thanks for the review @aaronspring 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add template xarray object kwarg to map_blocks 573768194

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);