home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 622128514

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3816#issuecomment-622128514 https://api.github.com/repos/pydata/xarray/issues/3816 622128514 MDEyOklzc3VlQ29tbWVudDYyMjEyODUxNA== 1312546 2020-04-30T21:38:21Z 2020-04-30T21:38:21Z MEMBER

Makes sense. template seems fine.

On Thu, Apr 30, 2020 at 3:35 PM Deepak Cherian notifications@github.com wrote:

Thanks for the review @TomAugspurger https://github.com/TomAugspurger

Question on the name template. I think in dask.dataframe and dask.array we might call this meta. Is that keyword already used elsewhere in xarray? template is also a fine name though.

I added the meta kwarg to apply_ufunc so that users could pass that down to dask i.e. that meta = dask's meta = np.ndarray or something like that. So I'd like to avoid reusing meta here where it would exclusively be an xarray object ≠ dask's meta

BUT it seems to me like there's a better name than template. Any ideas?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3816#issuecomment-622095710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAOIQWE7DGYAOSJWLG5F3RPHOI7ANCNFSM4K7ODDRA .

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  573768194
Powered by Datasette · Queries took 0.896ms · About: xarray-datasette