home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 622095710

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3816#issuecomment-622095710 https://api.github.com/repos/pydata/xarray/issues/3816 622095710 MDEyOklzc3VlQ29tbWVudDYyMjA5NTcxMA== 2448579 2020-04-30T20:35:13Z 2020-04-30T20:35:13Z MEMBER

Thanks for the review @TomAugspurger

Question on the name template. I think in dask.dataframe and dask.array we might call this meta. Is that keyword already used elsewhere in xarray? template is also a fine name though.

I added the meta kwarg to apply_ufunc so that users could pass that down to dask i.e. that meta = dask's meta = np.ndarray or something like that. So I'd like to avoid reusing meta here where it would exclusively be an xarray object ≠ dask's meta

BUT it seems to me like there's a better name than template. Any ideas?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  573768194
Powered by Datasette · Queries took 0.775ms · About: xarray-datasette