issue_comments

Table actions

9 rows where author_association = "MEMBER", issue = 510294810 and user = 4160723 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • benbovy · 9 ✖

issue 1

  • Html repr · 9 ✖

author_association 1

  • MEMBER · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
546229024 https://github.com/pydata/xarray/pull/3425#issuecomment-546229024 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NjIyOTAyNA== benbovy 4160723 2019-10-25T07:00:26Z 2019-10-25T07:00:26Z MEMBER

These are handled in the same way as long variable names, they truncate with an ellipsis and then expand on hover.

Oh yes I missed it. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
546072495 https://github.com/pydata/xarray/pull/3425#issuecomment-546072495 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NjA3MjQ5NQ== benbovy 4160723 2019-10-24T19:42:09Z 2019-10-24T19:42:09Z MEMBER

Cool!

I guess this post about how you use notebooks in your blog is still up to date?

I looks like we'll need to fix a couple of issues (the channel coordinate looks weird), but maybe it is not related to the front-end.

Besides variable names, we probably need to somehow handle overflow for variables that have a long list of dimension labels.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
546009495 https://github.com/pydata/xarray/pull/3425#issuecomment-546009495 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NjAwOTQ5NQ== benbovy 4160723 2019-10-24T16:57:57Z 2019-10-24T16:57:57Z MEMBER

Thanks a lot @jsignell ! It is great to see this merged finally!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545997936 https://github.com/pydata/xarray/pull/3425#issuecomment-545997936 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTk5NzkzNg== benbovy 4160723 2019-10-24T16:28:22Z 2019-10-24T16:28:22Z MEMBER

Yes it looks nice! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545978412 https://github.com/pydata/xarray/pull/3425#issuecomment-545978412 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTk3ODQxMg== benbovy 4160723 2019-10-24T15:42:02Z 2019-10-24T15:42:02Z MEMBER

Mmm this still looks weird on my side:

Which version of jupyterlab are you using?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545970448 https://github.com/pydata/xarray/pull/3425#issuecomment-545970448 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTk3MDQ0OA== benbovy 4160723 2019-10-24T15:24:24Z 2019-10-24T15:24:24Z MEMBER

I'd would rather wait before turning on html display by default. I'd be fine doing so on the next major release if until then we make sure that the rendering will look reasonably good in most front-end situations.

For example, it will really need better integration with jupyterlab dark themes (see below) and would potentially cause issues elsewhere too (nbsphinx, etc.). But we should probably figure that out after this PR is merged.

I've noticed an issue with the alignment of attributes in jupyterlab (1.1.4) (Firefox 69.0.3):

It looks good in the classic notebook.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545579133 https://github.com/pydata/xarray/pull/3425#issuecomment-545579133 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTU3OTEzMw== benbovy 4160723 2019-10-23T18:35:23Z 2019-10-23T18:35:23Z MEMBER

Or maybe "text" and "html"?

Hopefully "html" will eventually become the classic display :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
544840593 https://github.com/pydata/xarray/pull/3425#issuecomment-544840593 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NDg0MDU5Mw== benbovy 4160723 2019-10-22T07:35:37Z 2019-10-22T08:17:21Z MEMBER

Just one small issue in the gist with the vertical alignment within a variable row, and the height of the icon container (I'm using Firefox):

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
544839504 https://github.com/pydata/xarray/pull/3425#issuecomment-544839504 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NDgzOTUwNA== benbovy 4160723 2019-10-22T07:31:46Z 2019-10-22T07:31:46Z MEMBER

This is really nice @jsignell !

I'd really like to hear back from @benbovy about whether the fiddle css is more uptodate.

We did a lot of experiments, even some after starting the implementation in #1820, so I admit this is quite messy. I also did some clean-up and tweaks directly in that PR, so unfortunately there is no fiddle of reference that exactly corresponds to what's in here. Sorry for that!

The html/css in this PR is the cleanest one, I think.

The latest fiddles (for Dataset) are these two ones:

the only thing that looks funny to me is the alternating black-gray text coloring

In the HTML repr, the width of the space character is less large that for the monospace font used in the text repr, so I originally used this trick to better distinguish between the values in the inline data repr. Now that each value is encapsulated in it's own span, we could tweak the padding instead (or both... I don't have strong opinion on this).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);