home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 544839504

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3425#issuecomment-544839504 https://api.github.com/repos/pydata/xarray/issues/3425 544839504 MDEyOklzc3VlQ29tbWVudDU0NDgzOTUwNA== 4160723 2019-10-22T07:31:46Z 2019-10-22T07:31:46Z MEMBER

This is really nice @jsignell !

I'd really like to hear back from @benbovy about whether the fiddle css is more uptodate.

We did a lot of experiments, even some after starting the implementation in #1820, so I admit this is quite messy. I also did some clean-up and tweaks directly in that PR, so unfortunately there is no fiddle of reference that exactly corresponds to what's in here. Sorry for that!

The html/css in this PR is the cleanest one, I think.

The latest fiddles (for Dataset) are these two ones:

  • https://jsfiddle.net/Lmqq7yzz/9/
  • https://jsfiddle.net/1g04ykum/ (@shoyer's try for handling long variable names)

the only thing that looks funny to me is the alternating black-gray text coloring

In the HTML repr, the width of the space character is less large that for the monospace font used in the text repr, so I originally used this trick to better distinguish between the values in the inline data repr. Now that each value is encapsulated in it's own span, we could tweak the padding instead (or both... I don't have strong opinion on this).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  510294810
Powered by Datasette · Queries took 0.918ms · About: xarray-datasette