home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 545970448

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3425#issuecomment-545970448 https://api.github.com/repos/pydata/xarray/issues/3425 545970448 MDEyOklzc3VlQ29tbWVudDU0NTk3MDQ0OA== 4160723 2019-10-24T15:24:24Z 2019-10-24T15:24:24Z MEMBER

I'd would rather wait before turning on html display by default. I'd be fine doing so on the next major release if until then we make sure that the rendering will look reasonably good in most front-end situations.

For example, it will really need better integration with jupyterlab dark themes (see below) and would potentially cause issues elsewhere too (nbsphinx, etc.). But we should probably figure that out after this PR is merged.

I've noticed an issue with the alignment of attributes in jupyterlab (1.1.4) (Firefox 69.0.3):

It looks good in the classic notebook.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  510294810
Powered by Datasette · Queries took 0.514ms · About: xarray-datasette