issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 484270833 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • combine_by_coords fails with DataArrays · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
741908629 https://github.com/pydata/xarray/issues/3248#issuecomment-741908629 https://api.github.com/repos/pydata/xarray/issues/3248 MDEyOklzc3VlQ29tbWVudDc0MTkwODYyOQ== TomNicholas 35968931 2020-12-09T17:03:24Z 2020-12-09T17:03:24Z MEMBER

@aijams while that isn't quite how I think about it, I think that is an accurate description of what combine_by_coords does :blush:

I'm assuming the main issue here is to have combine_by_coords put a set of unnamed DataArrays into a single group and paste them together.

Yes - which involves making the assumption that these different unnamed DataArrays are actually the same physical variable, and so can be meaningfully combined into a group.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords fails with DataArrays 484270833
737591086 https://github.com/pydata/xarray/issues/3248#issuecomment-737591086 https://api.github.com/repos/pydata/xarray/issues/3248 MDEyOklzc3VlQ29tbWVudDczNzU5MTA4Ng== TomNicholas 35968931 2020-12-03T01:02:46Z 2020-12-03T01:02:46Z MEMBER

Hi @max-sixty good question, and it would be nice to fix this!

I think that if we go with the scheme suggested by @dcherian for handling this issue then it answers the question I posed in #3312 - the answer being that we care more about combine_by_coords happily accepting two unnamed DataArrays than we do about it being consistent with merge by throwing an error. If we're happy with that then I think it shouldn't be too difficult to finish off the PR in #3312?

(I think that this bug mentioned in #3312 is separate, and possibly deserves its own small issue.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords fails with DataArrays 484270833
736022156 https://github.com/pydata/xarray/issues/3248#issuecomment-736022156 https://api.github.com/repos/pydata/xarray/issues/3248 MDEyOklzc3VlQ29tbWVudDczNjAyMjE1Ng== max-sixty 5635139 2020-11-30T20:24:46Z 2020-11-30T20:24:46Z MEMBER

Hi @aijams — this issue is still current! There are some notes from @TomNicholas on this PR: https://github.com/pydata/xarray/pull/3312. Though it looks like there may be an outstanding question on @shoyer there.

@TomNicholas any thoughts on whether this is ready for a contribution?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords fails with DataArrays 484270833
531825386 https://github.com/pydata/xarray/issues/3248#issuecomment-531825386 https://api.github.com/repos/pydata/xarray/issues/3248 MDEyOklzc3VlQ29tbWVudDUzMTgyNTM4Ng== dcherian 2448579 2019-09-16T15:19:50Z 2019-09-16T15:20:59Z MEMBER

Thanks @friedrichknuth .

It looks like all the combine functions expect lists of Datasets, not DataArrays (see docstrings).

It should be relatively easily to make this work like merge which can take a list of Datasets or DataArrays. See this code in merge: https://github.com/pydata/xarray/blob/756c94164840e8c070bcd26681b97c31412909ae/xarray/core/merge.py#L593-L602

to_dataset will fail for unnamed DataArrays, but _to_temp_dataset() will succeed. It seems to me like we want lists of unnamed DataArrays to work (like in the first example), so call _to_temp_dataset when needed. Maybe @shoyer has an idea on how to implement that cleanly.

Can you send in a PR?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords fails with DataArrays 484270833
526263925 https://github.com/pydata/xarray/issues/3248#issuecomment-526263925 https://api.github.com/repos/pydata/xarray/issues/3248 MDEyOklzc3VlQ29tbWVudDUyNjI2MzkyNQ== dcherian 2448579 2019-08-29T16:31:41Z 2019-08-29T16:31:41Z MEMBER

What do you think of:

  1. If combine receives a list of unnamed DataArrays, we convert them to temp datasets and then pass datasets down to merge.

  2. If combine receives a list of named DataArrays, then merge will do the right thing.

  3. If combine receives a list containing both Datasets and unnamed DataArrays then merge will raise the right error.

So really it's just (1) that needs a special case in the combine functions?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords fails with DataArrays 484270833
526251545 https://github.com/pydata/xarray/issues/3248#issuecomment-526251545 https://api.github.com/repos/pydata/xarray/issues/3248 MDEyOklzc3VlQ29tbWVudDUyNjI1MTU0NQ== TomNicholas 35968931 2019-08-29T15:59:24Z 2019-08-29T15:59:24Z MEMBER

@dcherian is this a merge problem, or a combine_by_coords problem?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords fails with DataArrays 484270833
524517012 https://github.com/pydata/xarray/issues/3248#issuecomment-524517012 https://api.github.com/repos/pydata/xarray/issues/3248 MDEyOklzc3VlQ29tbWVudDUyNDUxNzAxMg== shoyer 1217238 2019-08-24T04:00:41Z 2019-08-24T04:00:41Z MEMBER

+1 we should make this work!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords fails with DataArrays 484270833

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);