home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 737591086

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3248#issuecomment-737591086 https://api.github.com/repos/pydata/xarray/issues/3248 737591086 MDEyOklzc3VlQ29tbWVudDczNzU5MTA4Ng== 35968931 2020-12-03T01:02:46Z 2020-12-03T01:02:46Z MEMBER

Hi @max-sixty good question, and it would be nice to fix this!

I think that if we go with the scheme suggested by @dcherian for handling this issue then it answers the question I posed in #3312 - the answer being that we care more about combine_by_coords happily accepting two unnamed DataArrays than we do about it being consistent with merge by throwing an error. If we're happy with that then I think it shouldn't be too difficult to finish off the PR in #3312?

(I think that this bug mentioned in #3312 is separate, and possibly deserves its own small issue.)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  484270833
Powered by Datasette · Queries took 0.685ms · About: xarray-datasette