home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 526263925

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3248#issuecomment-526263925 https://api.github.com/repos/pydata/xarray/issues/3248 526263925 MDEyOklzc3VlQ29tbWVudDUyNjI2MzkyNQ== 2448579 2019-08-29T16:31:41Z 2019-08-29T16:31:41Z MEMBER

What do you think of:

  1. If combine receives a list of unnamed DataArrays, we convert them to temp datasets and then pass datasets down to merge.

  2. If combine receives a list of named DataArrays, then merge will do the right thing.

  3. If combine receives a list containing both Datasets and unnamed DataArrays then merge will raise the right error.

So really it's just (1) that needs a special case in the combine functions?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  484270833
Powered by Datasette · Queries took 0.689ms · About: xarray-datasette