issue_comments

Table actions

12 rows where author_association = "MEMBER", issue = 438421176 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 12 ✖

issue 1

  • Typing for DataArray/Dataset · 12 ✖

author_association 1

  • MEMBER · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
505645154 https://github.com/pydata/xarray/pull/2929#issuecomment-505645154 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTY0NTE1NA== max-sixty 5635139 2019-06-25T22:23:21Z 2019-06-25T22:23:21Z MEMBER

Thanks @crusaderky !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505630653 https://github.com/pydata/xarray/pull/2929#issuecomment-505630653 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTYzMDY1Mw== max-sixty 5635139 2019-06-25T21:31:36Z 2019-06-25T21:31:36Z MEMBER

(AppVeyor fail looks unrelated)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505533789 https://github.com/pydata/xarray/pull/2929#issuecomment-505533789 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTUzMzc4OQ== max-sixty 5635139 2019-06-25T17:02:37Z 2019-06-25T17:02:37Z MEMBER

I was considering adding this into pep8speaks, but I think this fundamentally incompatible with pep8speak's design. It runs a handful of pre-specified linters, without actually installing/running user code. But something like mypy needs to actually have xarray and its dependencies installed to work.

Yes, good point.

I haven't spent much time with the GitHub Checks, but potentially could be a good fit - one issue with the simpler "Update the comment" model is that it doesn't encode to GH whether it's safe to merge, so projects need to duplicate the test in CI

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505527575 https://github.com/pydata/xarray/pull/2929#issuecomment-505527575 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTUyNzU3NQ== max-sixty 5635139 2019-06-25T16:46:33Z 2019-06-25T16:46:33Z MEMBER

By the way, I think I can write a script based on pep8speaks that writes/updates GitHub comments from within from Travis or Azure Pipelines. We could use that for surfacing mypy results in pull requests. I will probably give that a try over the next few days....

That would be v cool. I'm kinda surprised something like pep8speaks doesn't do this already tbh...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505496869 https://github.com/pydata/xarray/pull/2929#issuecomment-505496869 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTQ5Njg2OQ== max-sixty 5635139 2019-06-25T15:29:05Z 2019-06-25T15:29:05Z MEMBER

Ah it works! Didn't know permissions transferred to forks.

@crusaderky hope that's OK, not wanting to step on your toes here...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505274907 https://github.com/pydata/xarray/pull/2929#issuecomment-505274907 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTI3NDkwNw== max-sixty 5635139 2019-06-25T04:14:22Z 2019-06-25T04:20:40Z MEMBER

Great, I've resolved those comments @shoyer , thanks: https://github.com/max-sixty/xarray/tree/annotations

@crusaderky we should be ready to go - maybe take a glance over to ensure you're happy.

I added a whatsnew with both of us - hope that's OK

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505158224 https://github.com/pydata/xarray/pull/2929#issuecomment-505158224 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTE1ODIyNA== max-sixty 5635139 2019-06-24T20:02:54Z 2019-06-24T20:02:54Z MEMBER

Cool, I think it should be a straight fast-forward merge from my branch to yours, and then an easy merge to master

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
505124409 https://github.com/pydata/xarray/pull/2929#issuecomment-505124409 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNTEyNDQwOQ== max-sixty 5635139 2019-06-24T18:24:10Z 2019-06-24T18:24:10Z MEMBER

Just fixed some more merge conflicts over at https://github.com/max-sixty/xarray/tree/annotations.

Thoughts on merging this now and continuing off master?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
504296594 https://github.com/pydata/xarray/pull/2929#issuecomment-504296594 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwNDI5NjU5NA== max-sixty 5635139 2019-06-21T05:37:55Z 2019-06-21T05:37:55Z MEMBER

@crusaderky I updated my branch slightly: - Couple of merge conflicts - Couple of issues around dict / OrderedDict. I tried to stay as close as possible while making the tests pass (I don't think I undid any of your most recent changes - if I did it was a mistake - feel free to modify) - I wonder whether we should merge this and then continue; I worry we'll get a constant tax of merge conflicts given how many places this touches

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
502486292 https://github.com/pydata/xarray/pull/2929#issuecomment-502486292 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwMjQ4NjI5Mg== max-sixty 5635139 2019-06-16T21:13:32Z 2019-06-16T21:13:32Z MEMBER

Great, thanks @crusaderky ! Let me know if I can do anything to help!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
502302695 https://github.com/pydata/xarray/pull/2929#issuecomment-502302695 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDUwMjMwMjY5NQ== max-sixty 5635139 2019-06-14T22:45:05Z 2019-06-14T22:45:05Z MEMBER

@crusaderky I finished this off as best I could. Tests pass though needs a review. Here's the code: https://github.com/max-sixty/xarray/tree/annotations

(I tried pasting a patch, but I my git-fu isn't enough to exclude all the master code given there's a merge commit in there)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176
487694226 https://github.com/pydata/xarray/pull/2929#issuecomment-487694226 https://api.github.com/repos/pydata/xarray/issues/2929 MDEyOklzc3VlQ29tbWVudDQ4NzY5NDIyNg== max-sixty 5635139 2019-04-29T18:36:02Z 2019-04-29T18:36:02Z MEMBER

Thanks @crusaderky , this looks great!

Re:

Switching all variable names from str to Hashable. Without proper unit tests however (out of scope) non-string hashables are expected not work most of the times. My preference would still be to stay limited on str...

Curious on others' thoughts. I would vote to allow Hashable for data variable names in Datasets - similar to other Mappings - but less so for dimension names in arrays. (Not opposed to it per se, open to instances where that would be helpful)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing for DataArray/Dataset 438421176

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);