issue_comments: 487694226

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2929#issuecomment-487694226 https://api.github.com/repos/pydata/xarray/issues/2929 487694226 MDEyOklzc3VlQ29tbWVudDQ4NzY5NDIyNg== 5635139 2019-04-29T18:36:02Z 2019-04-29T18:36:02Z MEMBER

Thanks @crusaderky , this looks great!

Re:

Switching all variable names from str to Hashable. Without proper unit tests however (out of scope) non-string hashables are expected not work most of the times. My preference would still be to stay limited on str...

Curious on others' thoughts. I would vote to allow Hashable for data variable names in Datasets - similar to other Mappings - but less so for dimension names in arrays. (Not opposed to it per se, open to instances where that would be helpful)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   438421176