issue_comments

I guess we should probably roll back the "name to scalar coordinates" part of this change.

@Zac-HD do you want to do that here or should we go with @TomNicholas's PR?

@pep8speaks seems to have gone hay-wire -- maybe you have a syntax error?

Thinking about this a little more, one hazard of converting names into index labels is that we lose the invariant that you get the same result regardless of order in which you call concat, e.g., something like these expressions could now give different results: xarray.concat([a, b], dim='x') vs xarray.concat([xarray.concat([a], dim='x'), xarray.concat([b], dim='x')], dim='x') If a and b have the same name, then you'd get an index with the two duplicate entries in the second case but not the first case.

I'm not entirely sure this is a deal-breaker but it makes me a little nervous reluctant. In particular, it might break some the invariants we're relying upon for the next version of open_mfdataset (https://github.com/pydata/xarray/pull/2616, cc @TomNicholas )

I'll check on the doc build failure, but I would rather not remove load_dataset yet -- we didn't deprecate it that long ago. On Fri, Feb 22, 2019 at 5:28 AM Zac Hatfield-Dodds notifications@github.com wrote:

@Zac-HD commented on this pull request.

In xarray/core/combine.py https://github.com/pydata/xarray/pull/2777#discussion_r259341037:

• elif name != arr.name:
• if compat == 'identical':
• raise ValueError('array names not identical')
• else:
• arr = arr.rename(name)
• datasets.append(arr._to_temp_dataset())
• name = result_name(arrays)
• names = [arr.name for arr in arrays]
• if compat == 'identical' and len(set(names)) != 1:
• raise ValueError(
• "compat='identical', but array names {!r} are not identical"
• .format(names if len(names) <= 10 else sorted(set(names)))
• )
• datasets = [arr.rename(name)._to_temp_dataset() for arr in arrays] +
• if isinstance(dim, str) and len(set(names) - {None}) == len(names) \

Not for this - we're checking that names is a list of unique strings.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2777#discussion_r259341037, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1nbwyPzYE3HzT30pWhWignDUrbBSks5vP_B_gaJpZM4bCN3h .