issue_comments: 466434007

I'll check on the doc build failure, but I would rather not remove load_dataset yet -- we didn't deprecate it that long ago. On Fri, Feb 22, 2019 at 5:28 AM Zac Hatfield-Dodds notifications@github.com wrote:

@Zac-HD commented on this pull request.

In xarray/core/combine.py https://github.com/pydata/xarray/pull/2777#discussion_r259341037:

• elif name != arr.name:
• if compat == 'identical':
• raise ValueError('array names not identical')
• else:
• arr = arr.rename(name)
• datasets.append(arr._to_temp_dataset())
• name = result_name(arrays)
• names = [arr.name for arr in arrays]
• if compat == 'identical' and len(set(names)) != 1:
• raise ValueError(
• "compat='identical', but array names {!r} are not identical"
• .format(names if len(names) <= 10 else sorted(set(names)))
• )
• datasets = [arr.rename(name)._to_temp_dataset() for arr in arrays] +
• if isinstance(dim, str) and len(set(names) - {None}) == len(names) \

Not for this - we're checking that names is a list of unique strings.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2777#discussion_r259341037, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1nbwyPzYE3HzT30pWhWignDUrbBSks5vP_B_gaJpZM4bCN3h .