issue_comments: 467648344

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2777#issuecomment-467648344 https://api.github.com/repos/pydata/xarray/issues/2777 467648344 MDEyOklzc3VlQ29tbWVudDQ2NzY0ODM0NA== 1217238 2019-02-26T22:52:28Z 2019-02-26T22:52:28Z MEMBER

@pep8speaks seems to have gone hay-wire -- maybe you have a syntax error?

Thinking about this a little more, one hazard of converting names into index labels is that we lose the invariant that you get the same result regardless of order in which you call concat, e.g., something like these expressions could now give different results: xarray.concat([a, b], dim='x') vs xarray.concat([xarray.concat([a], dim='x'), xarray.concat([b], dim='x')], dim='x') If a and b have the same name, then you'd get an index with the two duplicate entries in the second case but not the first case.

I'm not entirely sure this is a deal-breaker but it makes me a little nervous reluctant. In particular, it might break some the invariants we're relying upon for the next version of open_mfdataset (https://github.com/pydata/xarray/pull/2616, cc @TomNicholas )

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   411755105