issue_comments

Table actions

2 rows where author_association = "MEMBER" and issue = 395045813 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • ENH: switch Dataset and DataArray to use explicit indexes · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
451287136 https://github.com/pydata/xarray/pull/2639#issuecomment-451287136 https://api.github.com/repos/pydata/xarray/issues/2639 MDEyOklzc3VlQ29tbWVudDQ1MTI4NzEzNg== shoyer 1217238 2019-01-03T21:44:21Z 2019-01-03T21:44:21Z MEMBER

(This PR) Indexes are recreated from coordinates every time a new DataArray or Dataset is created.

Does it add some overhead (though I don't see any reason of it)?

I suppose another option would be to leave self._indexes = None in the constructor, and only set default values for self._indexes when the indexes property is accessed.

I think we do something like for a few other attributes already.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: switch Dataset and DataArray to use explicit indexes 395045813
451271931 https://github.com/pydata/xarray/pull/2639#issuecomment-451271931 https://api.github.com/repos/pydata/xarray/issues/2639 MDEyOklzc3VlQ29tbWVudDQ1MTI3MTkzMQ== fujiisoup 6815844 2019-01-03T20:46:53Z 2019-01-03T20:46:53Z MEMBER

@shoyer

It looks nice and reasonable to me.

(This PR) Indexes are recreated from coordinates every time a new DataArray or Dataset is created.

Does it add some overhead (though I don't see any reason of it)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: switch Dataset and DataArray to use explicit indexes 395045813

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);