issues: 395045813

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
395045813 MDExOlB1bGxSZXF1ZXN0MjQxNjExMTU4 2639 ENH: switch Dataset and DataArray to use explicit indexes 1217238 closed 0     2 2019-01-01T00:48:42Z 2019-01-04T21:07:45Z 2019-01-04T17:15:34Z MEMBER   0 pydata/xarray/pulls/2639

xref https://github.com/pydata/xarray/issues/1603

This change switches Dataset.indexes and DataArray.indexes to be backed by explicit dictionaries of indexes, instead of being implicitly defined by the set of coordinates with names matching dimensions.

There are no changes to the public interface yet: these will come later.

My current plan: 1. (This PR) Indexes are recreated from coordinates every time a new DataArray or Dataset is created. 2. (Follow-up PRs) Refactor indexes to be propagated explicitly in xarray operations. This will facilitate future API changes, when indexes will no longer only be associated with dimensions. I will probably add some testing decorator that can be used to mark part of a test as including no creation of default indexes. 3. Add explicit entries into indexes for MultiIndex levels that are checked instead of MultiIndex variables. Still no public API changes (aside from adding more entries to .indexes). 4. Support arbitrary coordinates in indexes.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2639/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables