issue_comments: 451287136

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2639#issuecomment-451287136 https://api.github.com/repos/pydata/xarray/issues/2639 451287136 MDEyOklzc3VlQ29tbWVudDQ1MTI4NzEzNg== 1217238 2019-01-03T21:44:21Z 2019-01-03T21:44:21Z MEMBER

(This PR) Indexes are recreated from coordinates every time a new DataArray or Dataset is created.

Does it add some overhead (though I don't see any reason of it)?

I suppose another option would be to leave self._indexes = None in the constructor, and only set default values for self._indexes when the indexes property is accessed.

I think we do something like for a few other attributes already.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   395045813