issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 381518663 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • shoyer · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
494487640 https://github.com/pydata/xarray/pull/2556#issuecomment-494487640 https://api.github.com/repos/pydata/xarray/issues/2556 MDEyOklzc3VlQ29tbWVudDQ5NDQ4NzY0MA== shoyer 1217238 2019-05-21T17:38:07Z 2019-05-21T17:38:07Z MEMBER

OK, in it goes!

Thanks for your patience @phausamann !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add transpose_coords option to DataArray.transpose 381518663
488199163 https://github.com/pydata/xarray/pull/2556#issuecomment-488199163 https://api.github.com/repos/pydata/xarray/issues/2556 MDEyOklzc3VlQ29tbWVudDQ4ODE5OTE2Mw== shoyer 1217238 2019-05-01T03:28:12Z 2019-05-01T03:28:12Z MEMBER

I just merged in master, let's see how that goes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add transpose_coords option to DataArray.transpose 381518663
440362603 https://github.com/pydata/xarray/pull/2556#issuecomment-440362603 https://api.github.com/repos/pydata/xarray/issues/2556 MDEyOklzc3VlQ29tbWVudDQ0MDM2MjYwMw== shoyer 1217238 2018-11-20T17:34:33Z 2018-11-20T17:34:33Z MEMBER

I'm not exactly sure how this works, there are a lot of tests where the warning is issued, especially calls to DataArray.T. Should I update all of these tests to transpose(..., transpose_coords=False)?

Yes, that would probably be the right call. Or maybe even switch to .transpose(transpose_coords=True) to future proof the behavior?

We try to avoid issuing warnings in xarray's own test suite so we notice issues (e.g., deprecations in upstream packages) when they arise. This also gives us some estimate of how much turmoil a change will cause for users -- if we end up with lots of internal warnings, then users will probably notice, too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add transpose_coords option to DataArray.transpose 381518663
439476589 https://github.com/pydata/xarray/pull/2556#issuecomment-439476589 https://api.github.com/repos/pydata/xarray/issues/2556 MDEyOklzc3VlQ29tbWVudDQzOTQ3NjU4OQ== shoyer 1217238 2018-11-16T18:02:52Z 2018-11-16T18:02:52Z MEMBER

As a default, I think we want transpose_coords=None.

If transpose_coords is None and there are coordinates to transpose, we can issue a FutureWarning about how the default behavior of transpose_coords will switch to True in the future.

I'm not sure whether fixing these tests to work with the new behavior should be part of the PR.

Yes, this would be ideal. It would be fine to use transpose_coords=False explicitly in tests, but we should silence all warnings.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add transpose_coords option to DataArray.transpose 381518663

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);