issue_comments: 440362603

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2556#issuecomment-440362603 https://api.github.com/repos/pydata/xarray/issues/2556 440362603 MDEyOklzc3VlQ29tbWVudDQ0MDM2MjYwMw== 1217238 2018-11-20T17:34:33Z 2018-11-20T17:34:33Z MEMBER

I'm not exactly sure how this works, there are a lot of tests where the warning is issued, especially calls to DataArray.T. Should I update all of these tests to transpose(..., transpose_coords=False)?

Yes, that would probably be the right call. Or maybe even switch to .transpose(transpose_coords=True) to future proof the behavior?

We try to avoid issuing warnings in xarray's own test suite so we notice issues (e.g., deprecations in upstream packages) when they arise. This also gives us some estimate of how much turmoil a change will cause for users -- if we end up with lots of internal warnings, then users will probably notice, too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   381518663