home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 439476589

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2556#issuecomment-439476589 https://api.github.com/repos/pydata/xarray/issues/2556 439476589 MDEyOklzc3VlQ29tbWVudDQzOTQ3NjU4OQ== 1217238 2018-11-16T18:02:52Z 2018-11-16T18:02:52Z MEMBER

As a default, I think we want transpose_coords=None.

If transpose_coords is None and there are coordinates to transpose, we can issue a FutureWarning about how the default behavior of transpose_coords will switch to True in the future.

I'm not sure whether fixing these tests to work with the new behavior should be part of the PR.

Yes, this would be ideal. It would be fine to use transpose_coords=False explicitly in tests, but we should silence all warnings.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  381518663
Powered by Datasette · Queries took 102.859ms · About: xarray-datasette