issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 320632674 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • ENH: added FacetGrid functionality to line plots · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
394406007 https://github.com/pydata/xarray/pull/2107#issuecomment-394406007 https://api.github.com/repos/pydata/xarray/issues/2107 MDEyOklzc3VlQ29tbWVudDM5NDQwNjAwNw== shoyer 1217238 2018-06-04T15:54:51Z 2018-06-04T15:54:51Z MEMBER

thanks @yohai!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: added FacetGrid functionality to line plots 320632674
394060337 https://github.com/pydata/xarray/pull/2107#issuecomment-394060337 https://api.github.com/repos/pydata/xarray/issues/2107 MDEyOklzc3VlQ29tbWVudDM5NDA2MDMzNw== shoyer 1217238 2018-06-02T05:33:27Z 2018-06-02T05:33:27Z MEMBER

It looks like the merge went OK, but you have a couple of tests that are failing. Click on the "Travis-CI" link above next to the red "X" to see details: https://travis-ci.org/pydata/xarray/jobs/386973465

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: added FacetGrid functionality to line plots 320632674
394040124 https://github.com/pydata/xarray/pull/2107#issuecomment-394040124 https://api.github.com/repos/pydata/xarray/issues/2107 MDEyOklzc3VlQ29tbWVudDM5NDA0MDEyNA== shoyer 1217238 2018-06-02T00:12:59Z 2018-06-02T00:12:59Z MEMBER

Thanks @shoyer. I fixed everything except for the coverall part, which is weird. The lines it marks as untested are the function _line_facetgrid, which the main function that performs all of the testing. I suspect that it simply doesn't run my new tests for some reason. When I run pytest locally these lines do get tested (I verified by adding print commands there). Should I add decorators like pytest.mark.somethingfor coverall to notice these tests?

The specific problematic lines are those marked red in coveralls, e.g., https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L101 https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L176 https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L291

These are all cases where an error is raised.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: added FacetGrid functionality to line plots 320632674
388637796 https://github.com/pydata/xarray/pull/2107#issuecomment-388637796 https://api.github.com/repos/pydata/xarray/issues/2107 MDEyOklzc3VlQ29tbWVudDM4ODYzNzc5Ng== fmaussion 10050469 2018-05-13T16:09:45Z 2018-05-13T16:09:45Z MEMBER

writing new functions that will verify that stuff works as it should

Yes. See here for example tests for FacetGrid. Testing plotting functions is not trivial but we usually test only very basic functionality. You might find some examples in here.

or that the new addition does not mess up previous plotting behavior?

This is usually covered by continuous integration, which already ran the tests on your current PR (the "all checks have passed" green button above). So on this side you are safe for now, unless our previous tests weren't efficient enough ;-)

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: added FacetGrid functionality to line plots 320632674
387798725 https://github.com/pydata/xarray/pull/2107#issuecomment-387798725 https://api.github.com/repos/pydata/xarray/issues/2107 MDEyOklzc3VlQ29tbWVudDM4Nzc5ODcyNQ== jhamman 2443309 2018-05-09T16:33:31Z 2018-05-09T16:33:31Z MEMBER

@yohai - this looks great. Can we add some basic unit tests covering this functionality? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: added FacetGrid functionality to line plots 320632674
386927718 https://github.com/pydata/xarray/pull/2107#issuecomment-386927718 https://api.github.com/repos/pydata/xarray/issues/2107 MDEyOklzc3VlQ29tbWVudDM4NjkyNzcxOA== shoyer 1217238 2018-05-07T00:15:20Z 2018-05-07T00:15:20Z MEMBER

I'm really excited about this!

Could you kindly paste in examples of what the generated plots look like in your comment? (GitHub will upload an image when you paste it in.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: added FacetGrid functionality to line plots 320632674

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);