home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 394040124

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2107#issuecomment-394040124 https://api.github.com/repos/pydata/xarray/issues/2107 394040124 MDEyOklzc3VlQ29tbWVudDM5NDA0MDEyNA== 1217238 2018-06-02T00:12:59Z 2018-06-02T00:12:59Z MEMBER

Thanks @shoyer. I fixed everything except for the coverall part, which is weird. The lines it marks as untested are the function _line_facetgrid, which the main function that performs all of the testing. I suspect that it simply doesn't run my new tests for some reason. When I run pytest locally these lines do get tested (I verified by adding print commands there). Should I add decorators like pytest.mark.somethingfor coverall to notice these tests?

The specific problematic lines are those marked red in coveralls, e.g., https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L101 https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L176 https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L291

These are all cases where an error is raised.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  320632674
Powered by Datasette · Queries took 76.81ms · About: xarray-datasette