home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 388637796

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2107#issuecomment-388637796 https://api.github.com/repos/pydata/xarray/issues/2107 388637796 MDEyOklzc3VlQ29tbWVudDM4ODYzNzc5Ng== 10050469 2018-05-13T16:09:45Z 2018-05-13T16:09:45Z MEMBER

writing new functions that will verify that stuff works as it should

Yes. See here for example tests for FacetGrid. Testing plotting functions is not trivial but we usually test only very basic functionality. You might find some examples in here.

or that the new addition does not mess up previous plotting behavior?

This is usually covered by continuous integration, which already ran the tests on your current PR (the "all checks have passed" green button above). So on this side you are safe for now, unless our previous tests weren't efficient enough ;-)

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  320632674
Powered by Datasette · Queries took 0.894ms · About: xarray-datasette