issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 292653302 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Add '_FillValue' to set of valid_encodings for netCDF4 backend · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
365360917 https://github.com/pydata/xarray/pull/1869#issuecomment-365360917 https://api.github.com/repos/pydata/xarray/issues/1869 MDEyOklzc3VlQ29tbWVudDM2NTM2MDkxNw== shoyer 1217238 2018-02-13T18:34:44Z 2018-02-13T18:34:44Z MEMBER

Yes, thanks @czr137 !

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add '_FillValue' to set of valid_encodings for netCDF4 backend 292653302
365352947 https://github.com/pydata/xarray/pull/1869#issuecomment-365352947 https://api.github.com/repos/pydata/xarray/issues/1869 MDEyOklzc3VlQ29tbWVudDM2NTM1Mjk0Nw== jhamman 2443309 2018-02-13T18:07:44Z 2018-02-13T18:07:44Z MEMBER

@shoyer - this looks good to me. At some point, we should formalize how backends validate their encodings but I don't think that needs to happen here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add '_FillValue' to set of valid_encodings for netCDF4 backend 292653302
362097521 https://github.com/pydata/xarray/pull/1869#issuecomment-362097521 https://api.github.com/repos/pydata/xarray/issues/1869 MDEyOklzc3VlQ29tbWVudDM2MjA5NzUyMQ== shoyer 1217238 2018-01-31T22:49:00Z 2018-01-31T22:49:00Z MEMBER

We don't need any additional documentation, but we should note this bug fix in "What's new"

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add '_FillValue' to set of valid_encodings for netCDF4 backend 292653302
361488957 https://github.com/pydata/xarray/pull/1869#issuecomment-361488957 https://api.github.com/repos/pydata/xarray/issues/1869 MDEyOklzc3VlQ29tbWVudDM2MTQ4ODk1Nw== shoyer 1217238 2018-01-30T06:20:08Z 2018-01-30T06:20:08Z MEMBER

Oops! Yes, this is was definitely a bug.

Can you add a unit test for this, so we don't have a regression?

Take a look at the test test_explicitly_omit_fill_value added in https://github.com/pydata/xarray/pull/1659 and test_encoding_same_dtype below it for examples.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add '_FillValue' to set of valid_encodings for netCDF4 backend 292653302

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);