home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 361488957

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1869#issuecomment-361488957 https://api.github.com/repos/pydata/xarray/issues/1869 361488957 MDEyOklzc3VlQ29tbWVudDM2MTQ4ODk1Nw== 1217238 2018-01-30T06:20:08Z 2018-01-30T06:20:08Z MEMBER

Oops! Yes, this is was definitely a bug.

Can you add a unit test for this, so we don't have a regression?

Take a look at the test test_explicitly_omit_fill_value added in https://github.com/pydata/xarray/pull/1659 and test_encoding_same_dtype below it for examples.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  292653302
Powered by Datasette · Queries took 0.674ms · About: xarray-datasette