issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 247697176 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Reusing coordinate doesn't show in the dimensions · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
326384128 https://github.com/pydata/xarray/issues/1499#issuecomment-326384128 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyNjM4NDEyOA== shoyer 1217238 2017-08-31T18:34:50Z 2017-08-31T18:34:50Z MEMBER

What were you thinking for test coverage?

Simple things that match your use-cases. For example: indexing, arithmetic, aggregating over an axis, transpose, concatenating, saving/loading files, plotting. The xarray docs could be a good place to start to make sure you aren't missing anything big.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
326151060 https://github.com/pydata/xarray/issues/1499#issuecomment-326151060 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyNjE1MTA2MA== jhamman 2443309 2017-08-30T23:57:13Z 2017-08-30T23:57:13Z MEMBER

@acrosby - any interest in helping add support for this use case in xarray? Starting point would be to write some tests that target this use case. Then there will be bugs to fix...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
320038109 https://github.com/pydata/xarray/issues/1499#issuecomment-320038109 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyMDAzODEwOQ== jhamman 2443309 2017-08-03T17:34:29Z 2017-08-03T17:34:29Z MEMBER

I'm concerned about trying to support any of this behavior. I think any use of the datamodel with duplicate dimensions will be very buggy. Logic like this is all over the place:

Python def get_axis_num(self, dim) if isinstance(dim, basestring): return self._get_axis_num(dim)

In your example, you'd want this method to return (0, 1) but it would just return 0. Unless we have a strong argument against, I would think we should deprecate any of this behavior.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
320025438 https://github.com/pydata/xarray/issues/1499#issuecomment-320025438 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyMDAyNTQzOA== shoyer 1217238 2017-08-03T16:44:32Z 2017-08-03T16:44:32Z MEMBER

Yes, this is a bug.

But note that you will probably run into other issues with repeated dimension names. It's not explicitly forbidden by the data model, but various operation (like broadcasting) will fail, possibly in unpredictable ways.

Another example would be da.mean('x'), which may or may not be do the right thing. I don't think anyone has thought careful about these operations.

There's no reason why you shouldn't be able to support these for at least some subset of operations, but it will need some attention from an interested party.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);