issue_comments

Table actions

9 rows where issue = 247697176 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Reusing coordinate doesn't show in the dimensions · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
528699124 https://github.com/pydata/xarray/issues/1499#issuecomment-528699124 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDUyODY5OTEyNA== chrisroat 1053153 2019-09-06T04:06:05Z 2019-09-06T04:07:01Z CONTRIBUTOR

Just flying by and dropping a note because I just ran into this with Imaris Open files being created by a microscope camera. I wanted to use one of my favorite packages (xarray) to dig into the data, and noted the dimension reuse. Not a big blocker, but this functionality of the data format might be growing in usage.

More details on Imaris. http://open.bitplane.com/Default.aspx?tabid=268

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
517736527 https://github.com/pydata/xarray/issues/1499#issuecomment-517736527 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDUxNzczNjUyNw== acrosby 865212 2019-08-02T15:08:24Z 2019-08-02T15:08:24Z NONE

I think I side with @jhamman now on this issue. Labeled access to this kind of dataarray and broadcasting operations are not useful in my cases, and working in straight numpy or pandas ends up making more sense. We just drop the appropriate variables upon opening the relevant files.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
517420285 https://github.com/pydata/xarray/issues/1499#issuecomment-517420285 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDUxNzQyMDI4NQ== stale[bot] 26384082 2019-08-01T19:13:35Z 2019-08-01T19:13:35Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
326384128 https://github.com/pydata/xarray/issues/1499#issuecomment-326384128 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyNjM4NDEyOA== shoyer 1217238 2017-08-31T18:34:50Z 2017-08-31T18:34:50Z MEMBER

What were you thinking for test coverage?

Simple things that match your use-cases. For example: indexing, arithmetic, aggregating over an axis, transpose, concatenating, saving/loading files, plotting. The xarray docs could be a good place to start to make sure you aren't missing anything big.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
326286406 https://github.com/pydata/xarray/issues/1499#issuecomment-326286406 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyNjI4NjQwNg== acrosby 865212 2017-08-31T12:54:22Z 2017-08-31T12:54:22Z NONE

@jhamman I'm interested in helping, but I definitely can't be timely unless we can get a project here at work that I can leverage for time. What were you thinking for test coverage?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
326151060 https://github.com/pydata/xarray/issues/1499#issuecomment-326151060 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyNjE1MTA2MA== jhamman 2443309 2017-08-30T23:57:13Z 2017-08-30T23:57:13Z MEMBER

@acrosby - any interest in helping add support for this use case in xarray? Starting point would be to write some tests that target this use case. Then there will be bugs to fix...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
324975826 https://github.com/pydata/xarray/issues/1499#issuecomment-324975826 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyNDk3NTgyNg== acrosby 865212 2017-08-25T16:49:07Z 2017-08-25T16:49:07Z NONE

This is important for some of my use cases, it's something we do a lot--as noted it is not forbidden by the netcdf format or CF standards.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
320038109 https://github.com/pydata/xarray/issues/1499#issuecomment-320038109 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyMDAzODEwOQ== jhamman 2443309 2017-08-03T17:34:29Z 2017-08-03T17:34:29Z MEMBER

I'm concerned about trying to support any of this behavior. I think any use of the datamodel with duplicate dimensions will be very buggy. Logic like this is all over the place:

Python def get_axis_num(self, dim) if isinstance(dim, basestring): return self._get_axis_num(dim)

In your example, you'd want this method to return (0, 1) but it would just return 0. Unless we have a strong argument against, I would think we should deprecate any of this behavior.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176
320025438 https://github.com/pydata/xarray/issues/1499#issuecomment-320025438 https://api.github.com/repos/pydata/xarray/issues/1499 MDEyOklzc3VlQ29tbWVudDMyMDAyNTQzOA== shoyer 1217238 2017-08-03T16:44:32Z 2017-08-03T16:44:32Z MEMBER

Yes, this is a bug.

But note that you will probably run into other issues with repeated dimension names. It's not explicitly forbidden by the data model, but various operation (like broadcasting) will fail, possibly in unpredictable ways.

Another example would be da.mean('x'), which may or may not be do the right thing. I don't think anyone has thought careful about these operations.

There's no reason why you shouldn't be able to support these for at least some subset of operations, but it will need some attention from an interested party.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reusing coordinate doesn't show in the dimensions 247697176

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);