home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 320038109

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1499#issuecomment-320038109 https://api.github.com/repos/pydata/xarray/issues/1499 320038109 MDEyOklzc3VlQ29tbWVudDMyMDAzODEwOQ== 2443309 2017-08-03T17:34:29Z 2017-08-03T17:34:29Z MEMBER

I'm concerned about trying to support any of this behavior. I think any use of the datamodel with duplicate dimensions will be very buggy. Logic like this is all over the place:

Python def get_axis_num(self, dim) if isinstance(dim, basestring): return self._get_axis_num(dim)

In your example, you'd want this method to return (0, 1) but it would just return 0. Unless we have a strong argument against, I would think we should deprecate any of this behavior.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  247697176
Powered by Datasette · Queries took 2.042ms · About: xarray-datasette