issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 173640823 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Added validation of attrs before saving to netCDF files · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
244505226 https://github.com/pydata/xarray/pull/991#issuecomment-244505226 https://api.github.com/repos/pydata/xarray/issues/991 MDEyOklzc3VlQ29tbWVudDI0NDUwNTIyNg== shoyer 1217238 2016-09-02T22:52:09Z 2016-09-02T22:52:09Z MEMBER

thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added validation of attrs before saving to netCDF files 173640823
244264366 https://github.com/pydata/xarray/pull/991#issuecomment-244264366 https://api.github.com/repos/pydata/xarray/issues/991 MDEyOklzc3VlQ29tbWVudDI0NDI2NDM2Ng== shoyer 1217238 2016-09-02T02:03:20Z 2016-09-02T02:03:20Z MEMBER

This is almost there now.

I agree that we don't need to update the docs, but please do make note of it in "What's New".

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added validation of attrs before saving to netCDF files 173640823
243007669 https://github.com/pydata/xarray/pull/991#issuecomment-243007669 https://api.github.com/repos/pydata/xarray/issues/991 MDEyOklzc3VlQ29tbWVudDI0MzAwNzY2OQ== shoyer 1217238 2016-08-28T23:55:15Z 2016-08-28T23:55:15Z MEMBER

Take a look at the other netcdf tests -- they all use a decorator like @requires_netCDF4, either on the class or the method. That ensures they are skipped if required libraries for the functionality are not installed. On Sun, Aug 28, 2016 at 2:43 PM Robin Wilson notifications@github.com wrote:

Thanks, I'll deal with these modifications.

Also, I'm seeing errors from TravisCI saying ValueError: cannot read or write netCDF files without netCDF4-python or scipy installed - what do I need to do to make sure these tests work on Travis? (They pass fine on my local machine)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/991#issuecomment-243001377, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1qrd1mmelzaoL4omWV_TTLwAMeUSks5qkgEWgaJpZM4Ju5fU .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added validation of attrs before saving to netCDF files 173640823

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);