issues: 173640823

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
173640823 MDExOlB1bGxSZXF1ZXN0ODMwMTI0MzE= 991 Added validation of attrs before saving to netCDF files 296686 closed 0     6 2016-08-28T11:01:18Z 2016-09-02T22:52:09Z 2016-09-02T22:52:04Z CONTRIBUTOR   0 pydata/xarray/pulls/991

This allows us to give nice errors if users try to save a Dataset with attr values that can't be written to a netCDF file.

Fixes #911.

I've added tests to test_backends.py as I can't see a better place to put them. I've also made the tests fairly extensive, but also used some helper functions to stop too much repetition. Please let me know if any of this doesn't fit within the xarray style.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/991/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables