issue_comments: 243007669

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/991#issuecomment-243007669 https://api.github.com/repos/pydata/xarray/issues/991 243007669 MDEyOklzc3VlQ29tbWVudDI0MzAwNzY2OQ== 1217238 2016-08-28T23:55:15Z 2016-08-28T23:55:15Z MEMBER

Take a look at the other netcdf tests -- they all use a decorator like @requires_netCDF4, either on the class or the method. That ensures they are skipped if required libraries for the functionality are not installed. On Sun, Aug 28, 2016 at 2:43 PM Robin Wilson notifications@github.com wrote:

Thanks, I'll deal with these modifications.

Also, I'm seeing errors from TravisCI saying ValueError: cannot read or write netCDF files without netCDF4-python or scipy installed - what do I need to do to make sure these tests work on Travis? (They pass fine on my local machine)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/991#issuecomment-243001377, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1qrd1mmelzaoL4omWV_TTLwAMeUSks5qkgEWgaJpZM4Ju5fU .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   173640823