issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 1085992113 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • DeprecationWarning regarding use of distutils Version classes · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
999717002 https://github.com/pydata/xarray/issues/6092#issuecomment-999717002 https://api.github.com/repos/pydata/xarray/issues/6092 IC_kwDOAMm_X847lniK mathause 10194086 2021-12-22T16:43:35Z 2021-12-22T16:43:35Z MEMBER

I agree that .parse is the preferred method when you are taking a version string from an outside source. If you were using a static/constant string then it would probably be fine to use Version.

True we could potentially use version.parse(h5netcdf.core.h5py.__version__) >= version.Version("3.0.0") in #6096.

I wasn't sure what the best approach would be for xarray given that LooseVersion is a public property on the duck array wrapper, right? I'm not sure if packaging's Version is backwards compatible and whether or not that matters inside xarray.

Good point. It's not really backwards compatible. packagings Version cannot be compared to a string (while LooseVersion can). However, DuckArrayModule is probably not meant as a public interface - or were you referring to something else?

https://github.com/pydata/xarray/blob/5e8de55321171f95ed9684c33aa47112bb2519ac/xarray/core/pycompat.py#L11-L13

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DeprecationWarning regarding use of distutils Version classes 1085992113
999157464 https://github.com/pydata/xarray/issues/6092#issuecomment-999157464 https://api.github.com/repos/pydata/xarray/issues/6092 IC_kwDOAMm_X847je7Y mathause 10194086 2021-12-21T23:16:17Z 2021-12-21T23:16:17Z MEMBER

We currently use from distutils.version import LooseVersion - any opinion if we should replace this by version.parse or by version.Version?

```python from distutils.version import LooseVersion from packaging import version

LooseVersion(xr.version) version.parse(xr.version) version.Version(xr.version)

currently:

if LooseVersion(mod.version) < LooseVersion(minversion): pass

options:

if version.parse(mod.version) < version.parse(minversion): pass

if version.Version(mod.version) < version.Version(minversion): pass

if Version(mod.version) < Version(minversion): pass ```

See https://packaging.pypa.io/en/latest/version.html

(I think version.parse either returns a Version or a LegacyVersion. A five minute search suggests this is the preferred method but probably someone has a more informed opinion.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DeprecationWarning regarding use of distutils Version classes 1085992113
999135386 https://github.com/pydata/xarray/issues/6092#issuecomment-999135386 https://api.github.com/repos/pydata/xarray/issues/6092 IC_kwDOAMm_X847jZia Illviljan 14371165 2021-12-21T22:25:09Z 2021-12-21T22:25:09Z MEMBER

It's started to show up in the xarray CI as well now: https://github.com/pydata/xarray/runs/4600524127?check_suite_focus=true

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DeprecationWarning regarding use of distutils Version classes 1085992113
999042101 https://github.com/pydata/xarray/issues/6092#issuecomment-999042101 https://api.github.com/repos/pydata/xarray/issues/6092 IC_kwDOAMm_X847jCw1 max-sixty 5635139 2021-12-21T19:36:14Z 2021-12-21T19:36:14Z MEMBER

Thanks @djhoese . Looks like we can update LooseVersion to packaging.version...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DeprecationWarning regarding use of distutils Version classes 1085992113

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);