home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 999717002

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6092#issuecomment-999717002 https://api.github.com/repos/pydata/xarray/issues/6092 999717002 IC_kwDOAMm_X847lniK 10194086 2021-12-22T16:43:35Z 2021-12-22T16:43:35Z MEMBER

I agree that .parse is the preferred method when you are taking a version string from an outside source. If you were using a static/constant string then it would probably be fine to use Version.

True we could potentially use version.parse(h5netcdf.core.h5py.__version__) >= version.Version("3.0.0") in #6096.

I wasn't sure what the best approach would be for xarray given that LooseVersion is a public property on the duck array wrapper, right? I'm not sure if packaging's Version is backwards compatible and whether or not that matters inside xarray.

Good point. It's not really backwards compatible. packagings Version cannot be compared to a string (while LooseVersion can). However, DuckArrayModule is probably not meant as a public interface - or were you referring to something else?

https://github.com/pydata/xarray/blob/5e8de55321171f95ed9684c33aa47112bb2519ac/xarray/core/pycompat.py#L11-L13

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1085992113
Powered by Datasette · Queries took 0.593ms · About: xarray-datasette