issue_comments: 999157464

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6092#issuecomment-999157464 https://api.github.com/repos/pydata/xarray/issues/6092 999157464 IC_kwDOAMm_X847je7Y 10194086 2021-12-21T23:16:17Z 2021-12-21T23:16:17Z MEMBER

We currently use from distutils.version import LooseVersion - any opinion if we should replace this by version.parse or by version.Version?

```python from distutils.version import LooseVersion from packaging import version

LooseVersion(xr.version) version.parse(xr.version) version.Version(xr.version)

currently:

if LooseVersion(mod.version) < LooseVersion(minversion): pass

options:

if version.parse(mod.version) < version.parse(minversion): pass

if version.Version(mod.version) < version.Version(minversion): pass

if Version(mod.version) < Version(minversion): pass ```

See https://packaging.pypa.io/en/latest/version.html

(I think version.parse either returns a Version or a LegacyVersion. A five minute search suggests this is the preferred method but probably someone has a more informed opinion.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1085992113