issue_comments

Table actions

4 rows where author_association = "CONTRIBUTOR" and user = 30908904 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • gabriel-abrahao · 4 ✖

author_association 1

  • CONTRIBUTOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
799635182 https://github.com/pydata/xarray/issues/3185#issuecomment-799635182 https://api.github.com/repos/pydata/xarray/issues/3185 MDEyOklzc3VlQ29tbWVudDc5OTYzNTE4Mg== gabriel-abrahao 30908904 2021-03-15T18:10:28Z 2021-03-15T18:10:28Z CONTRIBUTOR

Maybe this can be closed now, since #5021 changed the docs?

@naught101 Looks like those coordinates are now in the order as declared in the affine package (since rasterio >= 1.0). See also: https://rasterio.readthedocs.io/en/latest/topics/migrating-to-v1.html.

All coordinates are created correctly, so from my point of view, only the docs here have to be changed.

python from affine import Affine da = xr.open_rasterio('path_to_file.tif') transform = Affine(*da.attrs['transform']) nx, ny = da.sizes['x'], da.sizes['y'] x, y = np.meshgrid(np.arange(nx)+0.5, np.arange(ny)+0.5) * transform

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   open_rasterio does not read coordinates from netCDF file properly with netCDF4>=1.4.2 477081946
799064102 https://github.com/pydata/xarray/pull/5021#issuecomment-799064102 https://api.github.com/repos/pydata/xarray/issues/5021 MDEyOklzc3VlQ29tbWVudDc5OTA2NDEwMg== gabriel-abrahao 30908904 2021-03-15T03:27:14Z 2021-03-15T03:27:14Z CONTRIBUTOR

you could also use the CI to verify the changes (the doctests CI is pretty fast), but as I said we can leave that to a new PR.

Unless someone else has any comments I'll merge this tomorrow.

Just did that, thanks! Is there a way to make the CI run just the check I want it to?

I'm not sure if every doctest has to import xarray as xr and import numpy as np, so I added those just in case and it's passing.

Also, right multiplying matrices will be deprecated in numpy, so now transform is on the left side.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   GH5005 fix documentation on open_rasterio 828352998
799040308 https://github.com/pydata/xarray/pull/5021#issuecomment-799040308 https://api.github.com/repos/pydata/xarray/issues/5021 MDEyOklzc3VlQ29tbWVudDc5OTA0MDMwOA== gabriel-abrahao 30908904 2021-03-15T02:03:37Z 2021-03-15T02:03:37Z CONTRIBUTOR

@gabriel-abrahao, do you want to try converting the code block to doctest? Otherwise this looks good to me and should be ready for merging.

I tried, but building the documentation is failing on both my Linux computers just like in #4257 , so unfortunately I can't make it. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   GH5005 fix documentation on open_rasterio 828352998
729306620 https://github.com/pydata/xarray/issues/1408#issuecomment-729306620 https://api.github.com/repos/pydata/xarray/issues/1408 MDEyOklzc3VlQ29tbWVudDcyOTMwNjYyMA== gabriel-abrahao 30908904 2020-11-18T00:56:45Z 2020-11-18T00:56:45Z CONTRIBUTOR

As a related issue, we could use an option for .sel to keep the selected variable as a singleton coordinate (an array of shape (1,)) instead of making it a scalar. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel does not keep selected coordinate value in case with MultiIndex 228295383

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);