issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR" and issue = 978356586 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Enable `flox` in `GroupBy` and `resample` · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1124203598 https://github.com/pydata/xarray/pull/5734#issuecomment-1124203598 https://api.github.com/repos/pydata/xarray/issues/5734 IC_kwDOAMm_X85DAfxO aulemahal 20629530 2022-05-11T19:24:56Z 2022-05-11T19:25:11Z CONTRIBUTOR

Presumably you haven't found any bugs?

Not for now,, but I haven't done much and it wasn't very complex.

You can pass method as .mean(..., method=...)

Yes! I saw that, but I did search a bit. In fact, my idea was triggered partly because I'm lazy. My suggestion was to do something alike what xarray does with keep_attrs : a global/context option that changes the default value of method, so it doesn't need to be explicitly added everywhere.

Note you can only blockwise if all members of a group are in a single block.

Oh! I didn't catch that. My test data was already appropriately chunked.

Right now, I'd just like this to get merged :)

Haha, I understand. My idea, if pertinent, could be done in another PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable `flox` in `GroupBy` and `resample` 978356586
1124142026 https://github.com/pydata/xarray/pull/5734#issuecomment-1124142026 https://api.github.com/repos/pydata/xarray/issues/5734 IC_kwDOAMm_X85DAQvK aulemahal 20629530 2022-05-11T18:18:17Z 2022-05-11T18:18:17Z CONTRIBUTOR

Hi @dcherian and @andersy005, thanks a lot for this PR and for flox. I'm currently trying this with our climate indices library (xclim) and it works well! I get a clear improvement in performance,

In xclim's indicators, all groupby operations are time resampling ops and the best performance is achieved with method='blockwise', by far. Is there a plan to let users control the default method through something like xr.set_options ?

Like, use_flox could accept False, True or any method name? (The default still being map-reduce) ? What do you think? 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable `flox` in `GroupBy` and `resample` 978356586
904877178 https://github.com/pydata/xarray/pull/5734#issuecomment-904877178 https://api.github.com/repos/pydata/xarray/issues/5734 IC_kwDOAMm_X84171R6 github-actions[bot] 41898282 2021-08-24T18:30:37Z 2021-11-06T04:33:42Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   57m 10s :stopwatch: 16 290 tests 14 551 :heavy_check_mark: 1 739 :zzz: 0 :x: 90 936 runs  82 738 :heavy_check_mark: 8 198 :zzz: 0 :x:

Results for commit a2168df2.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable `flox` in `GroupBy` and `resample` 978356586

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);