issues: 978356586

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
978356586 MDExOlB1bGxSZXF1ZXN0NzE4OTU4Mzc1 5734 Enable `flox` in `GroupBy` and `resample` 13301940 closed 0     25 2021-08-24T18:09:28Z 2022-05-15T03:33:49Z 2022-05-15T02:38:29Z MEMBER   0 pydata/xarray/pulls/5734

This PR supersedes https://github.com/pydata/xarray/pull/4540. This is still a very rough draft :)

  • Closes
  • [x] Closes #4473
  • [x] Closes #4498
  • [x] Closes #659
  • [x] Closes #2237
  • [x] xref https://github.com/pangeo-data/pangeo/issues/271
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

TODO: - [x] flox vs legacy tests with nans - [x] test passing flox-specific kwargs like engine and method.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5734/reactions",
    "total_count": 8,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 8,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables