issue_comments

Sorry for the unresponsiveness. I confirm that using the asfloat conversion also works for me. Should I close the issue or should I let you do it ?

I included the proposed changes, thanks for the help.

However the new test I implemented does not go through and I fail to understand why. Would you be able to check ? The idea of the test is to ensure that lazy computations give the same results than normal ones. I tracked down the problem to line 1377 of computation.py: python demeaned_da_a = da_a - da_a.mean(dim=dim) # <-- this one returns nan upon computation (.compute()) demeaned_da_b = da_b - da_b.mean(dim=dim) # <-- this one returns the correct value although the input is masked with nans in the same way

The values before the mean call are: da_a.compute() = <xarray.DataArray <this-array> (x: 2, time: 2)> array([[ 1., 2.], [ 2., nan]]) da_b.compute() = <xarray.DataArray <this-array> (x: 2, time: 2)> array([[ 1., 2.], [ 1., nan]])

And for the means (dim is None): da_a.mean(dim=dim).compute()=<xarray.DataArray <this-array> ()> array(nan) da_b.mean(dim=dim).compute()=<xarray.DataArray <this-array> ()> array(1.33333333)

For non lazy computations everything seems fine.

I was referring to: https://github.com/pydata/xarray/pull/5731#issuecomment-904403621

Otherwise I am working on the conflict with the main branch. Should be done soon.

@keewis indeed this was the problem. I removed it and corrected one test which did not have the @require_dask decorator.

There is still a test error with the test arrays 5 and 6: the lazy array version do not return the same value than the usual corr. I consider this a different bug and just removed the tests with a TODO in the code.

The last commit pass the tests on my machine and I added the whats-new text to version 0.19.1.

Concerning the tests I added a test to check that lazy correlations have identical results to non-lazy correlations. But this is not directly related to the bug fix. Indeed there is a need to have a test that checks if the non-lazy correlation works without dask installed. The already existing test function test_corr does not have a @requires_dask decorator. But it did not fail as it should have. Not sure why.

About documenting the changes, I am not sure of the whats-new.rst format and I thus did not add it. Should I just add a bullet item on the top of the file ?