home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 903574187

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5731#issuecomment-903574187 https://api.github.com/repos/pydata/xarray/issues/5731 903574187 IC_kwDOAMm_X84123Kr 9466648 2021-08-23T08:57:36Z 2021-08-23T08:57:36Z CONTRIBUTOR

Concerning the tests I added a test to check that lazy correlations have identical results to non-lazy correlations. But this is not directly related to the bug fix. Indeed there is a need to have a test that checks if the non-lazy correlation works without dask installed. The already existing test function test_corr does not have a @requires_dask decorator. But it did not fail as it should have. Not sure why.

About documenting the changes, I am not sure of the whats-new.rst format and I thus did not add it. Should I just add a bullet item on the top of the file ?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  976790237
Powered by Datasette · Queries took 0.716ms · About: xarray-datasette