home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 909095076

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5731#issuecomment-909095076 https://api.github.com/repos/pydata/xarray/issues/5731 909095076 IC_kwDOAMm_X842L7Ck 9466648 2021-08-31T10:10:15Z 2021-08-31T10:10:15Z CONTRIBUTOR

@keewis indeed this was the problem. I removed it and corrected one test which did not have the @require_dask decorator.

There is still a test error with the test arrays 5 and 6: the lazy array version do not return the same value than the usual corr. I consider this a different bug and just removed the tests with a TODO in the code.

The last commit pass the tests on my machine and I added the whats-new text to version 0.19.1.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  976790237
Powered by Datasette · Queries took 240.883ms · About: xarray-datasette