issue_comments

Table actions

5 rows where author_association = "CONTRIBUTOR" and issue = 460680578 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Add rename_vars and rename_dims · 5 ✖

author_association 1

  • CONTRIBUTOR · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
507773567 https://github.com/pydata/xarray/pull/3045#issuecomment-507773567 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzc3MzU2Nw== jukent 46687291 2019-07-02T17:30:59Z 2019-07-02T17:30:59Z CONTRIBUTOR

Added those tests for for the raised Value Error.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507350527 https://github.com/pydata/xarray/pull/3045#issuecomment-507350527 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzM1MDUyNw== jukent 46687291 2019-07-01T17:14:08Z 2019-07-01T17:14:08Z CONTRIBUTOR

Checks could be more complicated, but I think this is ready to merge!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
506070868 https://github.com/pydata/xarray/pull/3045#issuecomment-506070868 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNjA3MDg2OA== jukent 46687291 2019-06-26T22:39:31Z 2019-06-26T22:39:31Z CONTRIBUTOR

I would definitely recommend reading through our contributor's guide on how to setup a local environment for testing your code: http://xarray.pydata.org/en/stable/contributing.html

It is much easier to fix issues when you run tests locally rather than waiting on continuous integration tests (Travis-CI) to tell you that things are broken.

Thank you was just needing to look into this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
506009244 https://github.com/pydata/xarray/pull/3045#issuecomment-506009244 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNjAwOTI0NA== jukent 46687291 2019-06-26T19:17:14Z 2019-06-26T19:17:14Z CONTRIBUTOR

FYI tests are failing with E NameError: name '_rename_var_dims_helper' is not defined: https://travis-ci.org/pydata/xarray/jobs/550940568

Huh not sure why that is. I can remove that function and see if it works then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
505651365 https://github.com/pydata/xarray/pull/3045#issuecomment-505651365 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNTY1MTM2NQ== jukent 46687291 2019-06-25T22:50:51Z 2019-06-25T22:50:51Z CONTRIBUTOR

I uninstalled the bot that automatically closed the pull request #3042 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);