issue_comments

Table actions

4 rows where author_association = "CONTRIBUTOR" and issue = 436999500 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Implement load_dataset() and load_dataarray() · 4 ✖

author_association 1

  • CONTRIBUTOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
490321133 https://github.com/pydata/xarray/pull/2917#issuecomment-490321133 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ5MDMyMTEzMw== dnowacki-usgs 13837821 2019-05-08T02:17:52Z 2019-05-08T02:17:52Z CONTRIBUTOR

Sounds good. This latest commit un-deprecates tutorial.load_dataset() and makes it parallel to xarray.load_dataset() in terms of functionality. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
488369088 https://github.com/pydata/xarray/pull/2917#issuecomment-488369088 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4ODM2OTA4OA== dnowacki-usgs 13837821 2019-05-01T18:28:44Z 2019-05-01T18:28:44Z CONTRIBUTOR

Got it, thanks. I can make this change, assuming the dask argument used for deprecating it in the first place isn't stronger than maintaining this consistency.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
487810525 https://github.com/pydata/xarray/pull/2917#issuecomment-487810525 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4NzgxMDUyNQ== dnowacki-usgs 13837821 2019-04-30T03:21:21Z 2019-04-30T03:21:21Z CONTRIBUTOR

Forgive me, I don't understand what you mean by download vs open. I see that tutorial.load_dataset() is different from this PR in that it keeps the file handle open instead of closing it. Is that the distinction you are referring to? Otherwise all the gallery/examples I have checked call tutorial.load_dataset() at the beginning and that's it. Unless I'm missing something?

https://github.com/pydata/xarray/blob/6d93a95d05bdbfc33fff24064f67d29dd891ab58/xarray/tutorial.py#L92-L107

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
487449159 https://github.com/pydata/xarray/pull/2917#issuecomment-487449159 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4NzQ0OTE1OQ== dnowacki-usgs 13837821 2019-04-29T04:32:27Z 2019-04-29T04:32:27Z CONTRIBUTOR

Seems like undeprecating it makes sense as a function with identical functionality is being added here. What if we just imported the new load_dataset as xarray.tutorial.load_dataset for the purposes of the tutorial?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);