issue_comments

Table actions

10 rows where issue = 436999500 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Implement load_dataset() and load_dataarray() · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
493115946 https://github.com/pydata/xarray/pull/2917#issuecomment-493115946 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ5MzExNTk0Ng== shoyer 1217238 2019-05-16T15:28:41Z 2019-05-16T15:28:41Z MEMBER

LGTM, too. Thanks @dnowacki-usgs !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
493111419 https://github.com/pydata/xarray/pull/2917#issuecomment-493111419 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ5MzExMTQxOQ== dcherian 2448579 2019-05-16T15:17:34Z 2019-05-16T15:17:34Z MEMBER

LGTM. Thanks @dnowacki-usgs 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
490321133 https://github.com/pydata/xarray/pull/2917#issuecomment-490321133 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ5MDMyMTEzMw== dnowacki-usgs 13837821 2019-05-08T02:17:52Z 2019-05-08T02:17:52Z CONTRIBUTOR

Sounds good. This latest commit un-deprecates tutorial.load_dataset() and makes it parallel to xarray.load_dataset() in terms of functionality. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
488403346 https://github.com/pydata/xarray/pull/2917#issuecomment-488403346 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4ODQwMzM0Ng== shoyer 1217238 2019-05-01T20:17:29Z 2019-05-01T20:17:37Z MEMBER

I think the dask argument is really an argument that tutorial.open_dataset() needs to exist. But if we're also including a xarray.load_dataset() function, then for consistency it makes sense to have both tutorial options, too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
488369088 https://github.com/pydata/xarray/pull/2917#issuecomment-488369088 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4ODM2OTA4OA== dnowacki-usgs 13837821 2019-05-01T18:28:44Z 2019-05-01T18:28:44Z CONTRIBUTOR

Got it, thanks. I can make this change, assuming the dask argument used for deprecating it in the first place isn't stronger than maintaining this consistency.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
487827162 https://github.com/pydata/xarray/pull/2917#issuecomment-487827162 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4NzgyNzE2Mg== shoyer 1217238 2019-04-30T05:43:49Z 2019-04-30T05:44:21Z MEMBER

Forgive me, I don't understand what you mean by download vs open. I see that tutorial.load_dataset() is different from this PR in that it keeps the file handle open instead of closing it. Is that the distinction you are referring to?

The difference I was referring to is that xarray.tutorial.load_dataset() needs to call xarray.tutorial.open_dataset() internally, not xarray.open_dataset(). But otherwise it can look exactly like xarray.load_dataset, e.g., it should be: ```python

in tutorial.py

def load_dataset(args, kwargs): # this calls tutorial.open_dataset, not xarray.open_dataset with open_dataset(args, **kwargs) as ds: return ds.load() ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
487810525 https://github.com/pydata/xarray/pull/2917#issuecomment-487810525 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4NzgxMDUyNQ== dnowacki-usgs 13837821 2019-04-30T03:21:21Z 2019-04-30T03:21:21Z CONTRIBUTOR

Forgive me, I don't understand what you mean by download vs open. I see that tutorial.load_dataset() is different from this PR in that it keeps the file handle open instead of closing it. Is that the distinction you are referring to? Otherwise all the gallery/examples I have checked call tutorial.load_dataset() at the beginning and that's it. Unless I'm missing something?

https://github.com/pydata/xarray/blob/6d93a95d05bdbfc33fff24064f67d29dd891ab58/xarray/tutorial.py#L92-L107

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
487722453 https://github.com/pydata/xarray/pull/2917#issuecomment-487722453 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4NzcyMjQ1Mw== shoyer 1217238 2019-04-29T20:02:10Z 2019-04-29T20:02:10Z MEMBER

What if we just imported the new load_dataset as xarray.tutorial.load_dataset for the purposes of the tutorial?

tutorial.load_dataset() is a little different. It downloads the indicated file from GitHub to open instead of opening it directly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
487449159 https://github.com/pydata/xarray/pull/2917#issuecomment-487449159 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4NzQ0OTE1OQ== dnowacki-usgs 13837821 2019-04-29T04:32:27Z 2019-04-29T04:32:27Z CONTRIBUTOR

Seems like undeprecating it makes sense as a function with identical functionality is being added here. What if we just imported the new load_dataset as xarray.tutorial.load_dataset for the purposes of the tutorial?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500
486747316 https://github.com/pydata/xarray/pull/2917#issuecomment-486747316 https://api.github.com/repos/pydata/xarray/issues/2917 MDEyOklzc3VlQ29tbWVudDQ4Njc0NzMxNg== shoyer 1217238 2019-04-25T16:36:52Z 2019-04-25T16:36:52Z MEMBER

What do you think un-deprecating xarray.tutoral.load_dataset as part of this change? It might be useful to have that stick around for consistency.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement load_dataset() and load_dataarray() 436999500

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);