issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR" and issue = 297794911 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Remove flake8 from travis · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
369117775 https://github.com/pydata/xarray/pull/1919#issuecomment-369117775 https://api.github.com/repos/pydata/xarray/issues/1919 MDEyOklzc3VlQ29tbWVudDM2OTExNzc3NQ== Zac-HD 12229877 2018-02-28T04:27:16Z 2018-02-28T04:27:16Z CONTRIBUTOR

Last time I used it Hound didn't update the PR status, so if so that removes one of my objections 😄 As a maintainer I prefer automating checks - I make mistakes, especially when tired, and it's nice knowing that the system has my back.

Hound only runs checks in the diff range though, so I think it's still valuable to keep running flake8 ourselves. Trying both for a few months before making a final decision sounds like a good idea to me!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove flake8 from travis 297794911
369111117 https://github.com/pydata/xarray/pull/1919#issuecomment-369111117 https://api.github.com/repos/pydata/xarray/issues/1919 MDEyOklzc3VlQ29tbWVudDM2OTExMTExNw== Zac-HD 12229877 2018-02-28T03:38:47Z 2018-02-28T03:39:07Z CONTRIBUTOR

home-assistant uses https://houndci.com, and it seems to work pretty well for them - it just leaves a review with any flake8 comments at the relevant lines of the pull.

Note that while HoundCI is used to provide faster and more readable feedback to contributors, they still check flake8 in Travis to ensure everything is fixed before merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove flake8 from travis 297794911
369106191 https://github.com/pydata/xarray/pull/1919#issuecomment-369106191 https://api.github.com/repos/pydata/xarray/issues/1919 MDEyOklzc3VlQ29tbWVudDM2OTEwNjE5MQ== Zac-HD 12229877 2018-02-28T03:05:48Z 2018-02-28T03:05:48Z CONTRIBUTOR

I would be very disappointed to remove the flake8 check from Travis - in my experience, style guides are only applied consistently if they are enforced by CI.

Ensuring that each pull maintains our standards is much less burdensome than regular "big push" efforts to get back to the standard (see eg #1741 and #1824 - it took two people!), and avoids periods of lower code quality.

In short, I think that Travis is the right place to put these checks - review bots are a complement, not a substitute.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove flake8 from travis 297794911

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);