issue_comments: 369106191
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/1919#issuecomment-369106191 | https://api.github.com/repos/pydata/xarray/issues/1919 | 369106191 | MDEyOklzc3VlQ29tbWVudDM2OTEwNjE5MQ== | 12229877 | 2018-02-28T03:05:48Z | 2018-02-28T03:05:48Z | CONTRIBUTOR | I would be very disappointed to remove the flake8 check from Travis - in my experience, style guides are only applied consistently if they are enforced by CI. Ensuring that each pull maintains our standards is much less burdensome than regular "big push" efforts to get back to the standard (see eg #1741 and #1824 - it took two people!), and avoids periods of lower code quality. In short, I think that Travis is the right place to put these checks - review bots are a complement, not a substitute. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
297794911 |